Skip to content

Storage: transcript/tool-result stores on driver ports, residual failures and coverage (follow-up to #7783) #7809

Closed

Description

@senamakel

Part of #7522

Follow-up to #7783 (closed by #7807 for everything that was in reach).

Remaining

Activity

  1. added
    subtaskSubtask of a larger tracked effort.
    rust-coreCore Rust runtime in src/: CLI, core_server, shared infrastructure.
    on Oct 14, 2026
  2. added
    priority: p2Soon. Real but survivable — a rough edge, a gap, a thing that will bite later.
    on Oct 14, 2026
  3. tinysweeper commented on Oct 14, 2026

    @tinysweeper

    Follow-up tracking issue for residual storage/transcript work after #7783: moving stores onto driver ports, a flaky test in the full suite, raising diff coverage above the 80% gate, and fixing rust:layout line-limit violations. A collection of assorted remaining tasks rather than a single defect, so triaged as a task with p2 priority (broken gates have tracked follow-ups and no outage or data loss). No candidate duplicates exist, so prior art is null.

    Labelled priority: p2.

  4. added theissue type on Oct 14, 2026
  5. senamakel commented on Oct 14, 2026

    @senamakel
    MemberAuthor

    openhuman#7821: fixes the resolved-route channel test (bus ring overwrite), raises #7686 changed-line coverage 74.2% -> 83.4%; layout already green; tinyagents#453 re-pin still pending (#7821)

  6. senamakel commented on Oct 14, 2026

    @senamakel
    MemberAuthor

    openhuman#7821: fixes order-dependent channel test and raises #7686 changed-line coverage (#7821)

  7. added a commit that references this issue on Oct 14, 2026
  8. senamakel commented on Oct 14, 2026

    @senamakel
    MemberAuthor

    Progress: PRs in this stage: #7821 (merged) fixes the channel test (bus ring overwrite), raises #7686 changed-line coverage 74.2% -> 83.4%; rust:layout already green on main (prompt_tests.rs now 633 lines).

    REMAINING: tinyagents JSONL transcripts + ToolResultArtifactStore onto driver ports (tinyhumansai/tinyagents#453, issue still open; only #456 artifact store merged). After it lands, re-pin vendor/tinyagents here. Also noted: composio test direct_connected_integrations_fetches_schemas_without_backend_composio_route fails in the full lib run before and after #7821 (not in scope).

  9. senamakel commented on Oct 15, 2026

    @senamakel
    MemberAuthor

    Constraint for the host PR (coordination with the #7801 context work): the session_store / session_host adaptation must not add new calls to CoreContext::current() / CoreContext::scope() / scoped / current_slot / DispatchCtx::ambient, and must not read current_tenant / profile_key ambiently. Take the context (or the scoped storage handle) as an explicit parameter instead; those APIs are being deleted by the #7801 leaves. Merge upstream/main right before merging and keep the newer vendor/tinyagents main sha.

  10. senamakel commented on Oct 15, 2026

    @senamakel
    MemberAuthor

    tinyagents#461: WorkspaceStores + one-time read-only JSONL transcript import onto driver ports (first slice of tinyagents#453 transcript half; removal of path API deferred) (tinyhumansai/tinyagents#461)

  11. senamakel commented on Oct 15, 2026

    @senamakel
    MemberAuthor

    tinyagents#461 merged (0b03f02): workspace-dir transcript stores over tsd with one-time legacy JSONL import (tinyhumansai/tinyagents#461)

  12. senamakel commented on Oct 15, 2026

    @senamakel
    MemberAuthor

    Progress (stage close-out): PRs in this stage: tinyhumansai/tinyagents#461 (merged, 0b03f02, released as v2.7.0): WorkspaceStores plus one-time read-only JSONL transcript import onto driver ports. Earlier: #7821 (merged), tinyagents#446/#456.

    No checkbox ticked: the remaining item (transcripts + ToolResultArtifactStore on driver ports, tinyagents#453) is only partly done.

    REMAINING:

    1. openhuman host PR moving session_store, cron origin_delivery, threads/ops/edit, agent/session_store/agent_transcripts to WorkspaceStores, with the context passed explicitly (no new CoreContext::current/scope/ambient/current_tenant/profile_key calls). Partial work exists on branch storage-7809-host-1 (not pushed, no PR; vendor/tinyagents re-pinned to v2.7.0; session_store + threads edit switched). Needs tinyagents port variants of background append, view::get_page, spend::thread_spend before the rest can move.
    2. Re-pin vendor/tinyagents, then a tinyagents PR removing the path-taking transcript API, re-pin again, close tinyagents#453.
    3. ToolResultArtifactStore half.
    4. Composio full-suite failure (direct_connected_integrations_fetches_schemas_without_backend_composio_route) passes alone; not reproduced/root-caused.
  13. senamakel commented on Oct 15, 2026

    @senamakel
    MemberAuthor

    Note for the storage-7809-host-1 PR: merge upstream/main before merging. It now includes #7857 (test_support handlers take DispatchCtx; fixes the 'Storage e2e on MongoDB' build) and #7856 (ConversationStore::new and the threads::store free functions take &DispatchCtx first). Our threads/ops edit/transcript changes must pass the ctx through rather than resolve it ambiently. Also build with the e2e-test-support feature when checking.

  14. added a commit that references this issue on Oct 15, 2026
  15. senamakel commented on Oct 15, 2026

    @senamakel
    MemberAuthor

    Host half merged: #7859 (merge 072bb5f). It pins vendor/tinyagents at the main merge commit 3dbf2ef8cc of tinyagents#463 (release v2.8.0, cut by hand because the Release workflow computes v2.2.0 from the stale 2.1.4 workspace version and fails).

    Still pending, so this issue and tinyagents#453 stay open:

    • Remove the path-based transcript API from tinyagents (FileTranscriptLocator and the workspace-path entry points); the host no longer calls it.
    • Readers (threads transcript_get / token_usage / edit) key the store by the chat agent id; a chat_agent_id flip on an existing thread loses its prior turns. Needs the writer agent persisted with the thread or an agent-agnostic thread lookup (open thread on storage(#7809): key transcript reads by the request's tenant and move remaining readers onto the session store #7859).
    • tinyagents#463 follow-ups: idempotency scan should ignore keys dropped by a same-generation compaction (and the doc sentence claiming so is wrong today); thread listing should scan the durable entry log for roots whose index refresh failed.
    • Pre-existing flake on upstream/main: agent::session_store workspace::tests::releasing_defaults_lets_the_next_call_open_afresh fails in parallel runs (global FALLBACKS cleared by mod_tests).
  16. senamakel commented on Oct 15, 2026

    @senamakel
    MemberAuthor

    Gate for the final #7809 host PR (agreed with the #7801 work): before merging, run cargo check -p openhuman --features e2e-test-support --all-targets and build the MongoDB storage e2e targets with --no-run (the openhuman-cli storage e2e tests used by the 'Storage e2e on MongoDB' job). The #7801 leaf fu-7801e-6 touches threads ops (crud/purge), running_subagents and session_host/runtime_session, so whoever lands second merges upstream/main and adapts.

  17. senamakel commented on Oct 15, 2026

    @senamakel
    MemberAuthor

    tinyagents#466: removes the path-based transcript API (FileTranscriptLocator/History and workspace-path entry points), fixes the two #463 follow-ups with regression tests, and fixes the Release workflow's version source (tinyhumansai/tinyagents#466)

  18. senamakel commented on Oct 15, 2026

    @senamakel
    MemberAuthor

    tinyagents#466 merged (8f1bc5f24d): path-based transcript API removed, #463 findings fixed, release version script. Re-pin PR in openhuman still to follow. tinyhumansai/tinyagents#466

  19. senamakel commented on Oct 15, 2026

    @senamakel
    MemberAuthor

    openhuman#7871: re-pins tinyagents past the path-transcript-API removal, records a thread's transcript key so a chat_agent_id change keeps earlier turns readable/editable, and isolates the agent::session_store parallel races (#7871)

  20. added a commit that references this issue on Oct 15, 2026
  21. senamakel commented on Oct 15, 2026

    @senamakel
    MemberAuthor

    Progress (stage close-out). PRs in this stage: tinyagents#466 (merged, v2.9.0, 8f1bc5f24d): removes the path-based transcript API, fixes the #463 follow-ups, fixes the Release version source. openhuman#7871 (merged): re-pin, host fixture ports, per-thread transcript key (a chat_agent_id flip keeps earlier turns), agent::session_store race fixes. Earlier: #7821, tinyagents#461, #463, #446, #456. tinyagents#453 is closed.

    REMAINING (moved out of this stage): ToolResultArtifactStore onto driver ports, tracked in #7872. Not run locally: 80% changed-line coverage gate (CI measures it). The Release workflow still hits GH013 on the push step; v2.9.0 was created by hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Soon. Real but survivable — a rough edge, a gap, a thing that will bite later.rust-coreCore Rust runtime in src/: CLI, core_server, shared infrastructure.subtaskSubtask of a larger tracked effort.

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions