Skip to content

testdata: attempt to deflake timers/goroutines tests #5384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakebailey wants to merge 1 commit into
base: dev
Choose a base branch
from
+13 −0
Open

testdata: attempt to deflake timers/goroutines tests #5384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,21 @@ func runPlatTests(options compileopts.Options, tests []string, t *testing.T) {
isWASI := strings.HasPrefix(options.Target, "wasi")
isWebAssembly := isWASI || strings.HasPrefix(options.Target, "wasm") || (options.Target == "" && strings.HasPrefix(options.GOARCH, "wasm"))
isBaremetal := options.Target == "simavr" || options.Target == "cortex-m-qemu" || options.Target == "riscv-qemu"
scheduler := options.Scheduler
if scheduler == "" {
scheduler = spec.Scheduler
}

for _, name := range tests {
if scheduler == "threads" || scheduler == "cores" {
switch name {
case "goroutines.go", "timers.go":
// These tests intentionally check concurrent scheduling by
// comparing output order, which is not deterministic with
// threaded schedulers.
continue
}
}
if options.GOOS == "linux" && (options.GOARCH == "arm" || options.GOARCH == "386") {
switch name {
case "timers.go":
Expand Down
Loading