docs: fix WASI guide example to use //go:wasmexport - #512
Open
0pcom wants to merge 1 commit into
Open
Conversation
//go:wasmimport declares a host function and is only valid on
declarations without a body, so the example fails to compile:
main.go:4:6: can only use //go:wasmimport on declarations
The example defines a function for the host to call, which is
//go:wasmexport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes tinygo-org/tinygo#5572.
The "Using WASI" guide's example uses
//go:wasmimporton a function with a body, which fails to compile on current TinyGo://go:wasmimportdeclares a host function (and is only valid on body-less declarations). What the example defines is a function for the host to call, which is//go:wasmexport.Verified with tinygo 0.41.1: the corrected example compiles for
GOOS=wasip1 GOARCH=wasm, and the current one fails with exactly the error reported in the issue.