sigstore: reject in-toto statements with unknown top-level fields (SPEC §5.4)#106
Merged
Merged
Conversation
…EC §5.4) sigstore-python tolerates unknown top-level fields in the in-toto statement. Per SPEC §5.4 the statement MUST contain only the recognized fields (_type, subject, predicateType, predicate); reject_unknown_intoto_fields rejects any unknown top-level field after the statement is parsed. Tinfoil produces canonical statements, so an unknown field is non-canonical; this matches tinfoil-go/-rs/-js.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sigstore-python tolerates unknown top-level fields in the in-toto statement. Per SPEC §5.4 the statement MUST contain only the recognized fields (_type, subject, predicateType, predicate); reject_unknown_intoto_fields rejects any unknown top-level field after the statement is parsed. Tinfoil produces canonical statements, so an unknown field is non-canonical; this matches tinfoil-go/-rs/-js.
Summary by cubic
Enforce SPEC §5.4 by rejecting in-toto statements that include unknown top-level fields during DSSE verification. Aligns validation with
tinfoil-go/tinfoil-rs/tinfoil-jsand prevents accepting non-canonical statements.reject_unknown_intoto_fieldsto allow only_type,subject,predicateType,predicate._verify_dsse_bundle; raisesVerificationErrorlisting the extra fields.Written for commit 78449e2. Summary will update on new commits.