svg: IDPrefix keeps several documents on one page apart - #59
Merged
Merged
Conversation
Every SVG document counts its clip, marker and gradient ids from one and names its title and desc with fixed ids. Inline two charts into one HTML page and they share a namespace: the second chart's url(#c1) resolves to the first chart's clip path, cutting its cells to the wrong rectangle, and its aria-labelledby reads out the first chart's title. svg.IDPrefix puts a caller-chosen prefix in front of every id the document defines and every reference to one. With no prefix the output is byte for byte what it was. A prefix that cannot start an XML name is reported on Open, as a bad font is. geom.Text's doc now says outright that labels over a heatmap need the heatmap's ColorBy repeated on the text layer for the light/dark ink to follow the cells; the layer never reads the layer beneath it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LNzcSGVVqpaZ85k19GV3TK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every SVG document counts its clip, marker and gradient ids from one and
names its title and desc with fixed ids. Inline two charts into one HTML
page and they share a namespace: the second chart's url(#c1) resolves to
the first chart's clip path, cutting its cells to the wrong rectangle,
and its aria-labelledby reads out the first chart's title.
svg.IDPrefix puts a caller-chosen prefix in front of every id the
document defines and every reference to one. With no prefix the output
is byte for byte what it was. A prefix that cannot start an XML name is
reported on Open, as a bad font is.
geom.Text's doc now says outright that labels over a heatmap need the
heatmap's ColorBy repeated on the text layer for the light/dark ink to
follow the cells; the layer never reads the layer beneath it.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01LNzcSGVVqpaZ85k19GV3TK