backend/pdf: separate the font-file key from its object number - #52
Merged
Merged
Conversation
The FontDescriptor was written as "/FontFile22 0 R" for an embedded TrueType font: the key and the object number ran together into one name followed by a stray "0 R". Readers then treated the font as not embedded, and a PDF importer that re-serialises the dictionary (gofpdi) scrambled it. The CFF branch only worked because its key happened to carry a trailing space. The space now lives in the format string for both. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FontDescriptor of an embedded TrueType font was written as
/FontFile22 0 Rinstead of/FontFile2 2 0 R: the key ran into the object number. PDF readers then treat the font as not embedded (MuPDF: "non-embedded font using identity encoding"), and gofpdi scrambles the dictionary when importing the page into another document. The CFF branch only worked because its key carried a trailing space.TestTheDescriptorReferencesTheFontProgramfollows the reference for TrueType and CFF and checks it lands on the font-program stream. Red before the fix, green after.Found while importing figure pages into an fpdf report (terminal-mk2).
🤖 Generated with Claude Code