Switch logging from zap to slog, remove debug logging - #185
Open
nathanjcochran wants to merge 5 commits into
Open
Switch logging from zap to slog, remove debug logging#185nathanjcochran wants to merge 5 commits into
nathanjcochran wants to merge 5 commits into
Conversation
…rors Removes the per-step registration and proxy tracing so `tiger mcp start` is silent until something goes wrong, applies the "Method not found" guard to all four docs-proxy registrations, and makes `mcp start http` surface a Serve error instead of logging it and blocking on a dead listener.
nathanjcochran
force-pushed
the
nathan/improve-logging
branch
from
August 6, 2026 17:26
d53a5fc to
e7d9efa
Compare
nathanjcochran
marked this pull request as ready for review
August 6, 2026 19:51
nathanjcochran
changed the title
Askir
approved these changes
Aug 10, 2026
Askir
left a comment
Askir
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, I don't think the --debug change is problematic. And we are below 1.x so I think small "breaking" changes like this are definitely okay if we put them into the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
internal/loggingzap wrapper with the standard library'sslog, adopting the patterns Ghost uses.Logging is now reserved for the MCP server, which is the only long-running backend process the CLI hosts.
tiger mcp startbuilds a logger over the command's stderr and hands it tomcp.NewServer, which uses it for its own output and also passes it to the MCP SDK (which uses it for its own internal logging). Everywhere else — CLI commands, analytics, MCP install, the signal handler — writes to stdout/stderr directly or returns an error. Log statements outside the MCP server (which produced structured log lines interspersed with the normal CLI output, which looked pretty bad imo) were removed rather than converted. None of them seemed very useful anyways, except perhaps to the developer originally building the feature (but developers can always put in their own print statements as needed during development - I don't think they need to remain in the committed code).Within the MCP server the logging is deliberately sparse, matching Ghost: we mostly log failures that would otherwise be swallowed, not per-step tracing. Startup emits almost nothing, so the logs are mostly silent until something goes wrong.
Because there is no longer a log level to configure, the
debugconfig option,TIGER_DEBUG, and--debugare gone. This is technically a backwards-incompatible change, but I doubt many actual end-users were using that feature, so I think it's probably safe to remove. But definitely let me know if you disagree.