fix(cli): let group admins resolve group names - #209
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI’s group-name resolution path so group admins (and other non-space-admin members) can target a group by name via the member-accessible principal.resolve, while preserving admin-only bulk group enumeration for invitation flows.
Changes:
- Switch
me groupsingle-group name resolution fromgroup.list(admin-only) toprincipal.resolve(member-accessible) viaresolveSpacePrincipalId. - Add a focused unit test for
resolveGroupIdto ensure UUID short-circuiting and thatgroup.listis not called. - Add an e2e regression test verifying a group admin can manage membership by group name without gaining
group listaccess.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/cli/commands/group.ts | Routes single group-name resolution through principal.resolve to enable non-space-admin group admins to manage groups by name. |
| packages/cli/commands/group.test.ts | Unit coverage for the new resolveGroupId behavior (uses principal.resolve, skips network for UUIDs). |
| e2e/cli.e2e.test.ts | E2E coverage ensuring group admins can manage group membership by name while group list remains space-admin-only. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
principal.resolveTesting
./bun test packages/cli/commands/group.test.ts./bun run check./bun run check:full