fix(k8s): include entity kind/name in kubectl timeout error message#6762
Open
breezy-devs wants to merge 1 commit into
Open
fix(k8s): include entity kind/name in kubectl timeout error message#6762breezy-devs wants to merge 1 commit into
breezy-devs wants to merge 1 commit into
Conversation
510c5b8 to
7e57d43
Compare
Signed-off-by: Brent Hiranaka <brenthiranaka95@gmail.com>
7e57d43 to
eeacdce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3686
Problem
When
kubectl applytimed out, the error message only reported the duration:This gave no indication of which resource caused the timeout, making it hard to diagnose in deployments with many resources.
Additionally, the condition that triggered this error path was checking
wgCtx.Err()forcontext.DeadlineExceeded, butwgCtxis an errgroup context that only ever emitscontext.Canceled— nevercontext.DeadlineExceeded. This made the timeout error message completely unreachable.Fix
errinstead ofwgCtx.Err(), so the timeout error is actually returned whenescalatingUpdatetimes outThe message now reads:
Test
Added
TestTimeoutErrorMessageto verify the error message includes the timeout duration and the entity kind/name.