[jiro-by-nori]

Summary

🤖 Generated with Nori

Players can now pick any piece of a coaster and edit from there. Before, the only option was to demolish from the last piece.

• Select a piece.
  • From the park: click or tap a coaster's rails to open the ride window, then press Edit from this piece.
  • From the Ride construction window: with Track mode on, click or tap rails. Rails of another coaster switch the window to that coaster.
  • Effect: the piece pulses with a yellow outline and the window shows Selected piece N of M · <shape>. Selecting changes nothing on the track.
  • Trains, supports and riders: clicking one of these gives a hint instead of guessing a piece.
• Navigate.
  • Previous piece / Next piece walk along the track and wrap round a circuit.
  • Track end goes back to the old build-at-the-end mode, which is still the default when nothing is selected.
  • Build before this piece extends the track backwards from a section's first piece.
• Edit.
  • Demolish selected piece removes only that piece. It splits the track into sections, or opens a closed circuit there, and every later piece stays put.
  • After a demolish, the selection moves to the piece before the gap, so Build piece fills the gap.
  • Reconnecting closes the circuit again. The ride then needs a new test before it can open.
• Safety, following the existing busy rule. Track edits are refused while the ride is open, testing, has a train out, or has riders aboard. The message is "Close the ride and wait for its train to return empty before changing the track." Previously an edit silently force-closed an open ride and removed its trains.
• Station access stays consistent. Removing the station tile next to an entrance or exit detaches that entrance or exit. The ride then asks for a new one before it can open.
• Feedback text. Demolishing now says "Track piece removed." instead of "Track piece placed."

How it works

• Sim (src/sim/track/construction.ts):
  • A ride's track is one ring, or one or more open sections.
  • Any piece can be removed.
  • A placement can attach to any open end, which merges sections. closed is set only when everything forms a single ring.
  • head/tail track the section being built, so removeTrack -1 and the cursor behave as before.
  • No save format change: prev/next were already saved, and a save/load round trip with split sections is tested.
• Snapshot: new trackLinks (id, prev, next per track row).
• Coaster scene and picking: each sprite carries its pieceId and coasterPart. pickTrackPiece hit-tests coaster sprites only, by alpha and topmost first. Both Canvas2D and WebGL2 use the same pick targets, so rotation, stacked track and multi-tile pieces resolve to the visible piece.
• Selection: editor-only UI state (piece id plus a geometry signature, which catches reused ids). It is never saved.

Behaviour references (described in docs/mechanics/track.md §2.8; original code, clean-room)

• RCT2 manual (pp. 38–39): next/previous segment arrows, a highlighted selected piece, a bulldozer that removes the highlighted piece mid-track, and the rule that a ride must be closed to work on it. https://archive.org/details/rct_2_manual
• Middle deletions leave independent sections that must be reconnected before the ride can open: https://forums.openrct2.org/topic/582-starting-a-new-track-section and https://forums.openrct2.org/topic/3504-forcing-a-ride-open-non-complete-circuit

Test Plan

• pnpm lint, pnpm format:check, pnpm typecheck, pnpm test (all pass locally).
• New sim tests (track-editing.test.ts, track-edit-safety.test.ts):
  • Middle removal keeps the later pieces.
  • Gap rebuild, then test, then open, with a train carrying riders.
  • Several gaps filled in any order.
  • Backward build.
  • First and last piece.
  • Stale piece id.
  • Refusal while open, testing, or with a loaded train out. Allowed once the train is home.
  • Station removal detaches the entrance and exit.
  • Save/load of split track.
• New UI and picking unit tests: build-before placement checked against the sim, prev/next stepping and ring wrap, open ends, stationless ring numbering, picking that never maps a train or support click to a piece, and refusal versus warning classification.
• New e2e/track-edit-selection.spec.ts, WebGL2 and Canvas2D × desktop and Pixel 8 touch, 8/8 passing. Two flows:
  • Closed circuit: click a middle rail, check that exact piece is highlighted and nothing changed, demolish it, check the other 13 piece ids survive, rebuild, test, open, then a refused edit while open.
  • Unfinished and stacked track: pick the overpass, then the piece under it, demolish and reconnect, rotate the view and select again, then Previous to the first piece, build before it, Track end, and demolish last.
  • Editing in the closed-circuit flow runs while the game is paused.
• pnpm e2e:quick: 12 passed. 2 context-menu tests failed with Chromium "Target crashed"; the same crash happens on main's code in this environment.
• Coaster-related specs rerun. 10 failures in starter-ride-access, ride-access-repro and universal-clearance happen identically on main's code here (tile-coordinate calibration and timeouts). They are not caused by this PR, and CI does not run them.
• Full pnpm e2e (329 tests, one worker, this machine): 173 passed, 116 failed, 40 skipped. I reran all 116 failures with main's code (--last-failed) and 115 failed the same way, so they come from this environment (Chromium crashes, coordinate calibration, guest spawning, art), not from this PR. The one difference was stall-storefront "explains a stall whose window faces no footpath". It failed once and then passed on this branch, so it is flaky. None of the 8 new track-edit tests failed.

Proof (before/after screenshots): see the PR comment.

Requested in Nori: https://demo.norisessions.com/chat/01a16c13-c814-7295-9955-b11ff875ed14

Share Nori with your team: https://www.npmjs.com/package/nori-skillsets

[jiro-by-nori]

Proof: before and after (I checked every image myself)

All files are in the proofs branch at commit 1f97550e: https://github.com/tilework-tech/opencoaster/blob/1f97550ed509975a65c09c12afa41d6cb3133dea/pr-194
The README there explains each image.

Before (main)

In the track tool, a click on a middle rail only says the circuit is complete. Demolish last piece removes the end piece and reports "Track piece placed."

After, WebGL2 desktop, closed circuit

The clicked middle piece (7 of 14) is outlined, and nothing on the track changed:

Demolish selected piece removes only that piece. The other 13 piece ids survive, and the selection moves to the piece before the gap, with a preview of the next piece:

Build piece reconnects the circuit. The e2e then tests and opens the ride, and confirms that an edit on the open ride is refused.

After, stacked track, rotation and the other renderer and devices

• Canvas2D desktop, a piece under an overpass: https://github.com/tilework-tech/opencoaster/blob/1f97550ed509975a65c09c12afa41d6cb3133dea/pr-194/after/canvas2d-desktop-unfinished/stacked-lower-selected-full.png
• WebGL2 desktop, selection after rotating the view: https://github.com/tilework-tech/opencoaster/blob/1f97550ed509975a65c09c12afa41d6cb3133dea/pr-194/after/webgl2-desktop-unfinished/rotated-selected-full.png
• Pixel 8 touch:
  • WebGL2: https://github.com/tilework-tech/opencoaster/blob/1f97550ed509975a65c09c12afa41d6cb3133dea/pr-194/after/webgl2-pixel8-unfinished/stacked-lower-selected-full.png
  • Canvas2D: https://github.com/tilework-tech/opencoaster/blob/1f97550ed509975a65c09c12afa41d6cb3133dea/pr-194/after/canvas2d-pixel8-circuit/circuit-gap-full.png

[jiro-by-nori]

Live verification on https://opencoaster.noriagentic.com/ after #194 and the follow-up fix #195 (Previous piece now works on a closed circuit when nothing is selected). Pages deploy runs: https://github.com/tilework-tech/opencoaster/actions/runs/41431840467 and https://github.com/tilework-tech/opencoaster/actions/runs/41436435967 (both succeeded). Captures: https://github.com/tilework-tech/opencoaster/tree/8721b28da2d09e0df204d4416b850d1a159ca0d9/pr-194/live