Repository navigation
fix(export): keep footnote and caption links, mentions, emphasis, and images - #22
Merged
Merged
Conversation
… images Footnotes were flattened with .text(), dropping links, mention names, emphasis, and images inside footnotes; captions likewise lost their links. Keep their markup so the serializer and the image/mention steps see it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause of missing links/images in the @NoriAgent X Article for https://12gramsofcarbon.com/p/agentics-using-ai-should-be-joyful:
exportPostArtifactflattened eachdiv.footnotewith.text()(dropping the footnote's links, itsMentionToDOMname,<em>, and any images inside it) and each image caption with.text()(dropping caption links).Now a footnote's blocks are kept (first paragraph prefixed
[n]; X Articles have no in-page anchors), so the later mention and image steps handle them, and captions keep their markup.Verified against the live post: 8 → 11 images; restores footnote 5's link, the caption YouTube link, the Ritam Mehta mention, and footnote/caption emphasis.
Tests:
npm test76/76, lint clean,distrecompiled.