*: revert gRPC stream operation duration metrics#11048
Conversation
tikv#10339)" This reverts commit 0180647. Signed-off-by: JmPotato <github@ipotato.me>
This reverts commit fe8e20c. Signed-off-by: JmPotato <github@ipotato.me>
📝 WalkthroughWalkthroughThe PR removes gRPC stream send-duration instrumentation and wrappers across PD and MCS services, deletes the shared ChangesgRPC stream metrics removal
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/cherry-pick release-nextgen-202603 |
|
@JmPotato: once the present PR merges, I will cherry-pick it on top of release-nextgen-202603 in the new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11048 +/- ##
==========================================
+ Coverage 79.25% 79.29% +0.03%
==========================================
Files 541 540 -1
Lines 76037 76010 -27
==========================================
+ Hits 60262 60269 +7
+ Misses 11534 11502 -32
+ Partials 4241 4239 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@JmPotato: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
close tikv#11040\n\nRevert the gRPC stream operation duration metrics introduced in tikv#10254 and the dependent Grafana stream-send panels from tikv#10339. This removes `grpcutil.MetricsStream` and the peer-IP-labeled `grpc_stream_operation_duration_seconds` histograms from PD and MCS services, eliminating the unbounded cardinality leak until a safer replacement lands.\n\nSigned-off-by: JmPotato <github@ipotato.me> (cherry picked from commit 070828c) Signed-off-by: JmPotato <github@ipotato.me>
What problem does this PR solve?
Issue Number: close #11040
grpcutil.NewMetricsStreamregisters histogram children labeled by peer IP with no lifecycle cleanup. Long-running PD/MCS processes accumulate unbounded label series (observed ~840k series from ~18k historical IPs), inflating memory and/metricsscrape cost until scrapes fail.What is changed and how does it work?
Check List
Tests
Related changes
Release note
Summary by CodeRabbit