Add @fredchenbj to engine-sig reviewer#42
Merged
winkyao merged 1 commit intoDec 23, 2019
Conversation
Signed-off-by: fredchenbj <cfworking@163.com>
winkyao
approved these changes
Dec 23, 2019
cfzjywxk
pushed a commit
to cfzjywxk/community
that referenced
this pull request
Mar 27, 2023
* contributors: add sre bot command help doc * add pr commands * address comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: fredchenbj cfworking@163.com
I am Fu Chen, start contributing to TiKV since Jan 24, 2018.
I have submitted multiple PRs related to the engine component of TiKV.
tikv pr:
rust-rocksdb pr:
This PR adds me to the list of engine-sig reviewer. I have read the following documents and understood the expectation of a reviewer.
https://github.com/tikv/community/blob/master/sig/engine/workflow-zh_CN.md
https://github.com/tikv/community/blob/master/sig/engine/constitution-zh_CN.md
https://github.com/tikv/community/blob/master/GOVERNANCE-zh_CN.md