chore(ci): repin the own-CI reviewer to claude-sonnet-5 - #96
Merged
Merged
Conversation
tigers1997
force-pushed
the
ci/repin-review-model
branch
from
August 25, 2026 16:05
d971313 to
e419a57
Compare
22 tasks
Same tier and list price as claude-sonnet-4-6, so the v2.7.0 maintainer cost
decision stands unchanged -- this is a currency bump, not a re-opening of it.
Lands on its own rather than inside the currency stack because
anthropics/claude-code-action@v1 refuses to run when the PR's review.yml differs
from the copy on the default branch ("Workflow validation failed"). Carrying the
repin inside a feature branch silently disables the AI review on that PR and on
every PR stacked on it, with no red check to make it visible. A review.yml change
has to be its own PR, where verdict-gate's self-bootstrap escape hatch applies.
tigers1997
force-pushed
the
ci/repin-review-model
branch
from
August 25, 2026 17:46
e419a57 to
cc63ddd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
One line: the own-CI reviewer moves from
claude-sonnet-4-6toclaude-sonnet-5. Same tier, same list price — the v2.7.0 maintainer cost decision stands unchanged. This is a currency bump, not a re-opening of that call.Why it is its own PR, and not part of the currency stack. It started life inside
chore/upstream-currency(#92), which turned out to break the review gate on the entire stack:anthropics/claude-code-action@v1refuses to run when the PR'sreview.ymldiffers from the default branch's copy — a sensible guard against a PR rewriting the workflow that reviews it. The failure mode is the nasty kind: the action skips rather than fails, so there is no red check. #92–#95 all sat there looking like they were waiting on a reviewer that was never going to start. Confirmed it wasn't a credentials problem first — #88–#91 posted real VERDICT comments through 2026-06-27 on the same secret.So the repin has been lifted out of that stack (all four branches rebased;
review.ymlis now byte-identical to main on each) and lands here instead, where verdict-gate's self-bootstrap escape hatch is the designed handling for exactly this case.Worth writing down: any future
review.ymlchange has to be its own PR for the same reason. The CHANGELOG entry says so, since the symptom gives no hint of the cause.Type of change
Scope
review.ymlplus its CHANGELOG entry.templates/moves.Tests
python3 configure.py --checkpasses locally.review.ymlblob is byte-identical to main's apart from the model token — no line-ending or whitespace churn.CHANGELOG
## Unreleased.License & NOTICE
templates/discipline-skills/untouched by this PR.LICENSE/NOTICEuntouched.Signing
I understand
review.yml, which is precisely the condition that makes the action self-skip. That is the self-bootstrap caseCONTRIBUTING.mddescribes, and it needs a maintainer's eye on the one-line diff instead.CONTRIBUTING.md.Merge this LAST, after #92–#95. The same validation rule cuts both ways: the moment this lands, main's
review.ymlsaysclaude-sonnet-5while #92–#95 still carryclaude-sonnet-4-6, and the action self-skips on them all over again. They have already been reviewed against the currently-pinned model and passed, so there is nothing to gain by going first and a re-broken gate to lose. Order: #92 → #93 → #94 → #95 → this.