Skip to content

Migrate to single create_schema.gsql for Application Fraud kit#81

Open
akasper wants to merge 2 commits into
devfrom
akasper/fix-application-fraud-schema-syntax-error
Open

Migrate to single create_schema.gsql for Application Fraud kit#81
akasper wants to merge 2 commits into
devfrom
akasper/fix-application-fraud-schema-syntax-error

Conversation

@akasper
Copy link
Copy Markdown
Collaborator

@akasper akasper commented Mar 5, 2026

Intended to address issue 80: #80

@jim-limprasert-tigergraph
Copy link
Copy Markdown
Contributor

Hi Kasper,

Thanks for raising the issue here!

Some thoughts:

I'm fine with removing the local_schema.txt file - it currently wasn't being used in schema creation right now.

As for the create_schema.gsql file, the original file was trying to add from the global schema seen here: https://github.com/tigergraph/solution_kits/blob/dev/financial_crime/library/schema/general_global_financial_crime_super_schema.gsql

So I wasn't sure if we should change that here.


Oh another point - is it fine if you raise this request towards the dev branch and then we can promote that to main branch later?

@akasper akasper changed the base branch from main to dev May 20, 2026 14:42
@akasper
Copy link
Copy Markdown
Collaborator Author

akasper commented May 20, 2026

Hi @jim-limprasert-tigergraph! Thanks for the follow-up.

I think we want to mimic the intent of the local_schema.txt file and get the solution kit into a installs-without-error-by-default state.

As for targeting a different branch: I'm now targeting dev, per your request.

@akasper
Copy link
Copy Markdown
Collaborator Author

akasper commented Jun 2, 2026

@jim-limprasert-tigergraph bump

@jim-limprasert-tigergraph
Copy link
Copy Markdown
Contributor

Hi @akasper ! Thanks for the bump here.

Hmmm would you mind also pinging maybe @GabrielTigerGraph and/or Robert for more thoughts around this. The current solution kit, if I recall, kinda relies on some initialization script.

I have some following thoughts here:

  • the client could try to load the schema from this portion here and/or setup the graph from here or TG Savanna: https://dl.tigergraph.com/?tab=solution
    • that way, they don't have to run some scripts to set it up
    • with Savanna, the pre-processing queries will also be run as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants