Add grid overlay options to CLI with usage examples - #3
Open
kodzonko wants to merge 2 commits into
Open
Conversation
Introduce new command-line flags to allow users to download maps with different grid and marker configurations: - `--grid`: maps with grid overlay and markers - `--grid-no-markers`: maps with grid overlay without markers - `--grid-poi-markers`: maps with grid overlay and POI markers Update README.md with usage examples for the new options.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds additional download variants (grid overlay / POI markers) to the Tibia minimap installer and documents the new CLI flags.
Changes:
- Replaced the
if/elseflag handling with acasestatement to support more minimap variants. - Added README examples for
--grid,--grid-no-markers, and--grid-poi-markers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| install-tibia-maps | Expands CLI options and chooses the appropriate tibiamaps.io download URL via case. |
| README.md | Documents the new installer flags with usage examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
27
to
29
| zip_file_name="$(mktemp -t 'minimap-XXXXXX')"; | ||
| curl --progress-bar --location "${url}" > "${zip_file_name}"; | ||
| unzip -o -d "${DEST_DIR}" "${zip_file_name}"; |
Author
There was a problem hiding this comment.
keeping the original, unless requested by the author to change
| ;; | ||
| esac; | ||
| zip_file_name="$(mktemp -t 'minimap-XXXXXX')"; | ||
| curl --progress-bar --location "${url}" > "${zip_file_name}"; |
Author
There was a problem hiding this comment.
keeping the original, unless requested by the author to change
Author
|
@mathiasbynens could you review? I tested on my macos. |
Update the macOS installation script to include a usage function and proper argument handling for the new grid and marker options. Also update the README to reflect the available command-line flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add command-line flags to allow users to download maps with different grid and marker configurations:
--grid: maps with grid overlay and markers--grid-no-markers: maps with grid overlay without markers--grid-poi-markers: maps with grid overlay and POI markersSimilar to what is available with Linux installer: https://github.com/tibiamaps/tibia-maps-installer-linux/blob/main/install-tibia-maps
This I suggested in issue: #2