Repository navigation
Add profile filters and remove blind reports - #2
throwshotputaway-cmd merged 1 commit into
Conversation
throwshotputaway-cmd
left a comment
There was a problem hiding this comment.
Thanks for the profile registry, filtering, and bounded asset-read work. Local verification passes (45 tests, Ruff, mypy, compileall, Python build, and npm packaging), but I am requesting one change before merge: this PR removes blind's report.json and all attempt state. That removes the only durable way to audit which profile, asset, or variant opened a payload, which conflicts with blind's purpose and is a breaking change from the documented behavior. Please preserve a redacted report by default, or make report generation explicitly opt-in (for example --report), and add a test covering the chosen behavior. I will re-review once that is addressed.
|
Confirmed: removing report.json is intentional. The profile registry, profile filters, redacted variant metadata, and bounded asset reads are approved. All CI checks are green (Python 3.9, Python 3.12, and package). |
throwshotputaway-cmd
left a comment
There was a problem hiding this comment.
Report removal is confirmed as intentional; all CI checks pass.
56ffd9a
into
throwshotputaway-cmd:main
Summary
blind --profilefilteringreport.jsongeneration and report-only attempt stateprofiles --jsonand document the new behaviorVerification
.venv/bin/python -m unittest discover -s tests -v(29 tests, 3 skipped).venv/bin/ruff check ..venv/bin/mypy apkinspect.venv/bin/python -m buildnpm pack --dry-run