Skip to content

Add profile filters and remove blind reports - #2

Merged
throwshotputaway-cmd merged 1 commit into
throwshotputaway-cmd:mainfrom
MacTash:feat/profile-driven-discovery
Sep 24, 2026
Merged

throwshotputaway-cmd merged 1 commit into
throwshotputaway-cmd:mainfrom
MacTash:feat/profile-driven-discovery

Conversation

@MacTash

@MacTash MacTash commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • centralize built-in adapter variants in profile metadata
  • add repeatable blind --profile filtering
  • remove automatic report.json generation and report-only attempt state
  • redact variant values from profiles --json and document the new behavior

Verification

  • .venv/bin/python -m unittest discover -s tests -v (29 tests, 3 skipped)
  • .venv/bin/ruff check .
  • .venv/bin/mypy apkinspect
  • .venv/bin/python -m build
  • npm pack --dry-run

@throwshotputaway-cmd throwshotputaway-cmd left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the profile registry, filtering, and bounded asset-read work. Local verification passes (45 tests, Ruff, mypy, compileall, Python build, and npm packaging), but I am requesting one change before merge: this PR removes blind's report.json and all attempt state. That removes the only durable way to audit which profile, asset, or variant opened a payload, which conflicts with blind's purpose and is a breaking change from the documented behavior. Please preserve a redacted report by default, or make report generation explicitly opt-in (for example --report), and add a test covering the chosen behavior. I will re-review once that is addressed.

@throwshotputaway-cmd

Copy link
Copy Markdown
Owner

Confirmed: removing report.json is intentional. The profile registry, profile filters, redacted variant metadata, and bounded asset reads are approved. All CI checks are green (Python 3.9, Python 3.12, and package).

@throwshotputaway-cmd throwshotputaway-cmd left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Report removal is confirmed as intentional; all CI checks pass.

@throwshotputaway-cmd
throwshotputaway-cmd marked this pull request as ready for review September 24, 2026 14:32
@throwshotputaway-cmd
throwshotputaway-cmd merged commit 56ffd9a into throwshotputaway-cmd:main Sep 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants