SCAL-312776: deprecate V1/v2 homepage and keep V3 as default#530
Open
jishnupavithran007 wants to merge 2 commits into
Open
SCAL-312776: deprecate V1/v2 homepage and keep V3 as default#530jishnupavithran007 wants to merge 2 commits into
jishnupavithran007 wants to merge 2 commits into
Conversation
commit: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the AppEmbed configuration and related types to reflect the deprecation of V1 and V2 home page experiences, establishing V3 (ModularWithStylingChanges) as the new baseline. Key changes include updating JSDoc documentation to flag deprecated properties, removing the explicit modularHomeExperience parameter from URL generation (favoring homepageVersion), and updating unit tests to match these URL parameter changes. Feedback was provided regarding the placement of {@link} tags within @deprecated JSDoc blocks to ensure proper rendering and adherence to the repository's style guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.