Repository navigation
Send plain values straight to Base - #72
Merged
Merged
Conversation
A `json.key value` went through Template#set!, BaseWithExtensions#set! and Base#set!, each checking for a block or options it did not have. Those layers were the largest cost in a render outside of Oj, more so without YJIT where every call is paid in full. Template#set! now hands a value with no block, that is not a Props::Options, to a new Base#set_value!, which writes it directly. Searcher#set_value! ignores it, as Searcher#set! already did for values. extract! uses set_value! too, and set_content! skips the extension lookups when there are no options. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
json.key valuewent through Template#set!, BaseWithExtensions#set! and Base#set!, each checking for a block or options it did not have. Those layers were the largest cost in a render outside of Oj, more so without YJIT where every call is paid in full.Template#set! now hands a value with no block, that is not a Props::Options, to a new Base#set_value!, which writes it directly. Searcher#set_value! ignores it, as Searcher#set! already did for values. extract! uses set_value! too, and set_content! skips the extension lookups when there are no options.