Fix single generation tests - #421
Draft
thinklanguages wants to merge 1 commit into
Draft
Conversation
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
composer lint(fails: composer not installed)composer test(fails: composer not installed)npx vitest run tests/frontend/nuclen-admin-single-generation.test.ts(fails: npm registry blocked)https://chatgpt.com/codex/tasks/task_e_685d21ef313083278859ff6dd6057f55
Description by Korbit AI
What change is being made?
Enhance test mocking by adding a new mock implementation for
NuclenStartGenerationand replacevi.restoreAllMocks()withvi.clearAllMocks()in the test cleanup.Why are these changes being made?
This change ensures that the
NuclenStartGenerationfunction is properly mocked (allowing controlled test scenarios for asynchronous calls) and usesvi.clearAllMocks()instead ofvi.restoreAllMocks()to clean up only the mocks set during the test without affecting any global mock state, which maintains test isolation and improves reliability.