Skip to content

Refactoring for data_converters_validator.py #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViacheslavKlimov merged 2 commits into from
Nov 6, 2025
Merged

Refactoring for data_converters_validator.py #272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
881b8a8
Refactoring for data_converters_validator.py
ViacheslavKlimov Nov 4, 2025
3b85e70
Log test
artem-barysh-dev Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion data_converters_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,13 @@ def validate_uplink_downlink(directory):
raise ValueError(f"Directory '{directory}' is not recognized as 'uplink' or 'downlink'.")

result_value = actual_result.get()
output = result_value.get('outputMsg') if is_dedicated else json.loads(result_value.get('output'))
if is_dedicated:
output = result_value.get('outputMsg')
else:
output = result_value.get('output')
if not output:
raise ValueError(f"No 'output' field for converter from {directory} with payload {payload_file} and result {result_value}.")
output = json.loads(output)
error = result_value.get('error')

if error != '':
Expand Down