Repository navigation
fix: make ruff check and format pass - #151
Merged
AlexanderWillner merged 6 commits intoOct 26, 2026
Merged
Conversation
Add ruff.toml with target-version py38 (matches python_requires and CI), remove unused noqa directives, sort imports, normalize quotes via ruff format, drop stray shebang and executable bit.
3.8-3.10 are EOL, and 3.8 is no longer provided on ubuntu-26.04, which broke CI at setup-python. Drop them from the test matrix, bump python_requires and Pipfile, retarget Ruff to py311 and modernize annotations (PEP 585/604).
pipenv treats python_version as an exact requirement, not a minimum, so "3.11" broke deps-install on 3.12+. The minimum version lives in setup.py (python_requires >= 3.11).
Contributor
|
LGTM. |
Move ruff config (ruff.toml), project metadata (setup.py/setup.cfg)
cast() the single-task lookup in the test (tasks() returns a dict for a uuid), add a targeted pyright ignore for the py2app options stub limitation, and run pyright via pipenv so it resolves project imports.
|
Contributor
|
@AlexanderWillner Two things:
|
Contributor
|
@AlexanderWillner Also, now that we use pyproject.toml, we might be able to drop setup.py as well... by slightly rewriting some makefiles and workflows... I don't think we use py2app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 36c7acf:
ruff check .reported 44 findings (mostly pre-existing) andruff format --checkflagged two files.Verified:
ruff checkandruff format --checkpass, 37/37 unittests green.