feat(deployer): fetch logo from the <name>_web child for Phoenix umbrella apps - #305
Merged
Merged
Conversation
The logo lookup only checked the catalog app's own priv directory, which fails for Phoenix umbrella apps where logo.svg lives in the <name>_web child. The <name>_web atom is not known on the DeployEx node, so it is discovered from :application.loaded_applications/0 on the monitored node and probed for the logo. The single-app path is unchanged: the catalog name is resolved to an atom on the DeployEx node and its priv directory is read directly. The umbrella fallback only fires when the main app has no logo, and the result is cached by the caller so the extra RPC happens once per node. Risk assessment: - Impact: umbrella apps now show their logo in the dashboard instead of a blank image - Blast radius: Deployer.Status.Logo only; no other module is touched - Regression risk: low - the single-app path is unchanged and the umbrella path is purely additive, gated behind the main app returning no logo - Rollback: plain commit revert 🤖 Generated with [Devin](https://devin.ai) (GLM-5.2 High)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
privdirectory, which fails for Phoenix umbrella apps wherelogo.svglives in the<name>_webchild<name>_webatom is not known on the DeployEx node, so it is discovered from:application.loaded_applications/0on the monitored node and probed for the logoRisk assessment
Deployer.Status.Logoonly; no other module is touchedTest plan
mix format --check-formattedpassesmix credo --strictpasses (logo.ex)mix dialyzerpasses (0 errors)mix test apps/deployer/test/status/logo_test.exspasses (11 tests)logo.svgin<name>_web/priv/static/images/🤖 Generated with Devin (GLM-5.2 High)