Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(hooks): cache-handoff Stop hook wakes idle claude for a hand-off #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(hooks): cache-handoff Stop hook wakes idle claude for a hand-off #526
Changes from all commits
c0547e6File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When another Stop arrives during the 50-minute delay,
oldidentifies the Bash hook process, butsleepis a separate child. Killing Bash leaves that child reparented to PID 1 and sleeping for the full duration; repeated turns therefore accumulate exactly the sleeper processes this gate is intended to eliminate. Use a trap or process-group-aware cancellation that also terminates the child.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a persistent container, this pidfile remains after the hook fires or exits through a later gate, so a subsequent Stop can encounter it after that PID has been recycled. In that case this unconditional
killterminates an unrelated process owned by the same user, potentially including Claude or an active tool. Remove the pidfile on exit and/or record and validate process identity before signaling it.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.