tuf: preserve literal newlines inside string literals during canonical JSON serialization#420
Merged
Merged
Conversation
…l JSON serialization TUF uses OLPC's [Canonical JSON], which is not actually JSON. One of the big differences is that the only escaped sequences in strings are `"` and `"`. So it allows literal newlines, nulls, and other byte sequences that are not allowed in regular JSON strings. - Replace serde_json::to_string string literal serialization inside Value::write with escape_canonical_string so control characters like newlines remain unescaped literal 0x0a bytes per OLPC canonical JSON specification. - Add string and object key escaping edge-case unit tests. TAG=agy CONV=e4755785-ae11-4908-b13c-5b0db1e48498 [Canonical JSON]: theupdateframework/specification#92
kellerb
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TUF uses OLPC's Canonical JSON, which is not actually JSON. One of the big differences is that the only escaped sequences in strings are
"and\. So it allows literal newlines, nulls, and other byte sequences that are not allowed in regular JSON strings.