Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The heap reservation can starve non-vregion allocations unless the regular heap is increased or separated.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Enables automatic Intel PTL user-space LL support for Linux-overlay builds.
Changes:
- Automatically includes the PTL user-space LL overlay.
- Updates user-space heap and memory-domain configuration.
| File | Summary |
|---|---|
app/overlays/ptl/ll_userspace_overlay.conf |
Configures user-space LL memory and partitions; the regular heap must account for the reserved user heap. |
app/CMakeLists.txt |
Automatically includes the PTL user-space LL overlay. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # Allocate majority of heap to user-space but only | ||
| # via vregions. Keep 0x40000 for non-vregion allocs. | ||
| CONFIG_SOF_ZEPHYR_SYS_USER_HEAP_SIZE=0x40000 | ||
| CONFIG_SOF_ZEPHYR_HEAP_SIZE=0x60000 |
There was a problem hiding this comment.
Fixed in V2. Removed the number from comment, this is bound to get out-of-sync with the settings. The settings in this PR are intentional.
lyakh
left a comment
lyakh
left a comment
There was a problem hiding this comment.
does it already work with the debug overlay?..
Increase the max limit for memory partitions to allow running SOF with sof-ptl-nocodec.tplg when running all pipelines in user-space. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
When building ptl for Linux (i.e. os_linux_overlay.conf is in EXTRA_CONF_FILE), automatically append ll_userspace_overlay.conf so callers do not need to pass it explicitly. A double-inclusion guard is included for the case where the caller already lists it. This keeps os_linux_overlay.conf target-agnostic while ensuring all ptl Linux builds get the LL userspace configuration. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
0de921f to
49cc50d
Compare
|
@lyakh wrote:
Ack, retest today, with HDa generic and PTL nocodec, assert-enabled build also works. |
|
V2:
|
Following up to the longrunning PR #10558 , this PR contains final changes to toggle Intel PTL builds with Linux overlay, to run all audio pipelines in user-space.
The full user-space builds now cover all functionality required to run SOF with upstream topologies and is designed to cover all content we have in pull-request CI.
Some features not yet working (for these, need to build SOF without the overlay until support is added):