Conversation
lyakh
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
September 28, 2026 10:37
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Correct the aggregate registration lookup before approval.
Review effort: Lite
Findings: 1
What changed in this PR
Simplifies notifier address calculation and merges two split lines.
Changes:
- Simplifies callback handle lookup.
- Combines the allocator call onto one line.
- Critical issue: aggregate registration treats the sentinel list head as a callback node, risking memory corruption.
| File | Summary |
|---|---|
src/lib/notifier.c |
Updates notifier registration logic and formatting; aggregate registration requires correction. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kv2019i
reviewed
Sep 28, 2026
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
Not sure this is code worth keeping....
lgirdwood
approved these changes
Sep 28, 2026
lyakh
requested review from
LaurentiuM1234,
abonislawski,
fkwasowi,
iganakov,
marcinszkudlinski and
pblaszko
as code owners
September 29, 2026 09:08
lyakh
changed the title
kv2019i
approved these changes
Sep 29, 2026
The "flags" argument of notifier_register() is unused, remove it. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
wjablon1
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notifier registration flags are unused, remove them