Conversation
llext-manager is already merging .bss and .data for joined mapping since they both should be mapped as writable data, and linkage- assistance scripts already place them next to each other. But in some empty section cases that still breaks. Add a dedicated region for the joined memory range and use it for mapping. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
September 28, 2026 10:33
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes consistently preserve and reuse the merged writable memory range.
Review effort: Lite
Findings: None
What changed in this PR
Fixes LLEXT handling of merged writable .data/.bss memory ranges.
Changes:
- Stores the merged writable range in module state.
- Reuses it for unloading and memory-domain management.
| File | Description |
|---|---|
src/library_manager/llext_manager.c |
Tracks and uses the merged writable range. |
src/include/sof/lib_manager.h |
Adds the merged writable-range descriptor. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lgirdwood
approved these changes
Sep 28, 2026
Member
|
@lyakh gold standard for llext test seem to be tflm today. |
Collaborator
Author
@lgirdwood that's what this is fixing, yes |
wjablon1
approved these changes
Sep 29, 2026
Collaborator
Author
|
"Internal Intel CI" failed on WCL, trying to rerun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llext-manager is already merging .bss and .data for joined mapping since they both should be mapped as writable data, and linkage- assistance scripts already place them next to each other. But in some empty section cases that still breaks. Add a dedicated region for the joined memory range and use it for mapping.