Repository navigation
[feat] item dims on every row: size, box, tris, bytes, animated (core roadmap 39 P4) - #16
Merged
Merged
Conversation
… roadmap 39 P4) - tools/kit-build/lib/dims.mjs + `kit-build dims [pack…|--all] [--write] [--remote]`: measures each row's LOD0 (inspectGlb) and writes size [w, h, d] metres, box [minX..maxZ], tris, bytes and animated: true for files with clips. Number arrays stay on one line; the file keeps its own indent and newline style. - the CI: a `dims` check (missing or stale against the measured file, 1.5 mm slack on the bounds) + row-shape rules (dimsShapeProblems); `build` and `pass --write` re-measure, so a decimation can never leave a stale row behind. - one-off backfill of all 252 rows in the 12 model lists, the 21 Khronos rows measured from a --remote download (their bytes stay upstream). - tests: dims.test.mjs (5) + a missing-dims check test; the fixture writes measured dims so every other check test stays focused. 38/38 green; check 0 errors. Core reads these before any download (the drag-to-place ghost's W x D x H and the Explorer's download size). Serving needs the usual `format-1` retag + purge. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core roadmap 39 P4 (lane 39-place): item dimensions on every model-list row, so the app can show an item's size
before it downloads it (the drag-to-place ghost's W × D × H, the Explorer's download size). Core PR: theprototype-app/core#347.
tools/kit-build/lib/dims.mjs+node tools/kit-build/kit-build.mjs dims [pack…|--all] [--write] [--remote]:measures LOD0 and writes
size[w, h, d] metres,box[minX..maxZ],tris,bytes, andanimated: truefor afile with clips. Keeps each file's indent/newlines; number arrays on one line.
dimscheck (missing or stale vs the measured file, 1.5 mm slack on bounds) + row-shape rules;buildandpass --writere-measure, so a decimation never leaves a stale row.--remotedownload —their bytes stay upstream).
check: 0 errors. Tool tests 38/38 (5 new + a missing-dims check test).After merge: retag
format-1+ purge (README ritual) so the CDN serves the new rows. Until then core measureseach item on first load (correct, only "size unknown" before the download).
🤖 Generated with Claude Code