This repository was archived by the owner on Feb 13, 2019. It is now read-only.
allow clicktracking to fire on liveblog load new articles button - #204
Open
collin wants to merge 2 commits into
Open
allow clicktracking to fire on liveblog load new articles button#204collin wants to merge 2 commits into
collin wants to merge 2 commits into
Conversation
Contributor
|
@collin, intentional to include changes to the bulbs.poll test in this PR? |
kand
approved these changes
Nov 9, 2016
Contributor
Author
|
@spra85 Yeah, I've been trying to figure out some flaky tests. Looks like it isn't quite there yet :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The button was detaching before clicktracking was able to find the category/action/label.
@kand @spra85