Skip to content

Correct logic and behavior of FigureMedia, external IIIF images in TOC grids#1254

Draft
cbutcosk wants to merge 12 commits into
feature/figures-media-transformations-propertyfrom
feature/figures-plugin-sequence-annotation-derivatives
Draft

Correct logic and behavior of FigureMedia, external IIIF images in TOC grids#1254
cbutcosk wants to merge 12 commits into
feature/figures-media-transformations-propertyfrom
feature/figures-plugin-sequence-annotation-derivatives

Conversation

@cbutcosk

@cbutcosk cbutcosk commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

This PR corrects behaviors of the FigureMedia class to resolve #1232 and for overall correctness:

  • Refactors annotations and sequences computed properties to store factory-created annotations in a private property. Previously the factory for these properties was unnecessarily being called multiple times to create instances, upon each usage of the properties.
  • Eliminate unexpected behaviors for annoations by moving the execution of annotation asset handling to after the figure's core image assets have been processed. Annotation instances immediately produce JSON for their IIIF representation so they require asset paths populated by the image asset handling method.
  • Renames asset handling methods for clarity.
  • Refactors TOC grid item image component to use pre-calculated derivative media paths for applicable images, adds a test ensuring that behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant