Do not enable the plugin by default - #45
Merged
Merged
Conversation
stejskalleos
approved these changes
Nov 10, 2025
stejskalleos
left a comment
stejskalleos
left a comment
There was a problem hiding this comment.
Rubocop is not happy, but that's not because of the introduced changes.
Member
Author
|
That's because of theforeman/smart-proxy#924. |
This plugin always needs configuration to be effective so default to being off.
ekohl
force-pushed
the
do-not-enable-by-default
branch
from
November 10, 2025 14:47
b91370c to
9e799ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This plugin always needs configuration to be effective so default to being off.