Refs #39518 - Pin tls_ciphers to OpenSSL defaults in HTTPS integration tests - #954
Merged
adamruzicka merged 1 commit intoJul 14, 2026
Conversation
…n tests SSLClientVerificationIntegrationTest launches a real WEBrick HTTPS server without setting tls_ciphers, so it falls through to launcher.rb's crypto-policies auto-detection and inherits whatever the host's OpenSSL build happens to support. On a host where /etc/crypto-policies files are present but the linked OpenSSL doesn't understand the 'PROFILE=SYSTEM' cipher-list alias (e.g. a vendored, non-RHEL-patched OpenSSL), the test fails with a RuntimeError before ever reaching the actual SSL client verification behavior it's meant to check. Pin tls_ciphers to '' (OpenSSL defaults, no restriction) by default for HTTPS integration tests in test_helper.rb, so this test suite doesn't depend on the host's crypto-policies/OpenSSL combination. Auto-detection itself is already covered deterministically by the mocked unit tests in test/launcher_test.rb; this integration test only needs a working TLS handshake, not any particular cipher policy. This is a CI-only workaround; see #39518 for the underlying resolve_tls_ciphers robustness fix.
ogajduse
force-pushed
the
test/pin-tls-ciphers-in-https-integration-tests
branch
from
July 14, 2026 10:56
d3b2ff8 to
ca74355
Compare
adamlazik1
approved these changes
Jul 14, 2026
adamruzicka
approved these changes
Jul 14, 2026
Contributor
|
Thank you @ogajduse ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
smart-proxy-develop-source-release'sruby=3.0.4CI leg failsSSLClientVerificationIntegrationTestbecause it launches a real WEBrick HTTPS server without settingtls_ciphers, so it falls through tolauncher.rb's crypto-policies auto-detection and inherits whatever the host's OpenSSL build happens to support. On that leg,rbenv/ruby-buildvendors a plainopenssl-1.1.1wthat doesn't understand the'PROFILE=SYSTEM'cipher-list alias, even though the host's crypto-policies files are genuinely present — so the test fails with aRuntimeErrorbefore ever reaching the SSL client verification behavior it's actually meant to check. Root cause: https://projects.theforeman.org/issues/39518Fix
Pin
tls_ciphersto''(OpenSSL defaults, no cipher restriction) by default for HTTPS integration tests intest_helper.rb's sharedlaunchmethod — one place, so any current or future HTTPS integration test gets this automatically, not just this one file. A test can still overridetls_ciphersexplicitly via its ownsettings:hash if it wants to exercise a specific cipher value.Auto-detection of
tls_ciphersitself is already covered deterministically by the mocked unit tests intest/launcher_test.rb(File.exist?/OpenSSL probes are stubbed there) — this integration test only needs a working TLS handshake to check client-cert verification, not any particular cipher policy, so it shouldn't be coupled to the host's crypto-policies/OpenSSL combination at all.This is a CI-only workaround to unblock the pipeline. It does not touch production code or
resolve_tls_ciphers's behavior — see #39518 / a follow-up PR for the underlying robustness fix inlauncher.rbitself.Testing
developlauncher.rb(i.e. without any other fix applied):SSLClientVerificationIntegrationTestgoes from 6 errors → 4/4 passing.bundle exec rake test, excludingbmc/libvirtwhich need unrelated native system libs): 869/869 pass.