Skip to content

Fix libvirt dependency - #710

Open
michalgritzbach wants to merge 1 commit into
theforeman:masterfrom
michalgritzbach:add-libvirt-dependencies
Open

Fix libvirt dependency#710
michalgritzbach wants to merge 1 commit into
theforeman:masterfrom
michalgritzbach:add-libvirt-dependencies

Conversation

@michalgritzbach

@michalgritzbach michalgritzbach commented Jul 29, 2026

Copy link
Copy Markdown

Why are you introducing these changes? (Problem description, related links)

Foreman and Foreman's dev setup document assumes that libvirt is installed in the system. Without libvirt, Foreman's test suite fails to run (specifically https://github.com/theforeman/foreman/blob/develop/test/integration/host_js_test.rb#L4 - the require immediately stops the suite).

What are the changes introduced in this pull request?

  • adds libvirt-devel to foreman_development_packages
  • changes bundle install command in foreman_development role to include libvirt gem group

How to test this pull request

Steps to reproduce:

  • libvirt-devel is present, fog-libvirt (+ ruby-libvirt) are installed on a fresh system

Checklist

  • Tests added/updated (if applicable)
  • Documentation updated (if applicable)

@evgeni evgeni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could argue those tests could skip if there is no libvirt, instead of failing, but I am not in an arguing mood ;)

@evgeni
evgeni enabled auto-merge (rebase) July 30, 2026 09:09
@evgeni

evgeni commented Jul 30, 2026

Copy link
Copy Markdown
Member
No package libvirt-devel available.

I think on CentOS you need to enable crb repo for this.

@evgeni
evgeni disabled auto-merge July 30, 2026 09:31
@ares

ares commented Jul 30, 2026

Copy link
Copy Markdown
Member

Wouldn't it be nice if I could get dev environment ready to hack on any part of the Foreman? Perhaps forge can be extended with features-like concept if needed. While we can also start skipping tests, I'd still like to have a standard way to deploy dev environment for libvirt integration and more feature in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants