Fix libvirt dependency - #710
Open
michalgritzbach wants to merge 1 commit into
Open
Conversation
install libvirt gems.
evgeni
approved these changes
Jul 30, 2026
evgeni
left a comment
Member
There was a problem hiding this comment.
One could argue those tests could skip if there is no libvirt, instead of failing, but I am not in an arguing mood ;)
evgeni
enabled auto-merge (rebase)
July 30, 2026 09:09
Member
I think on CentOS you need to enable |
evgeni
disabled auto-merge
July 30, 2026 09:31
Member
|
Wouldn't it be nice if I could get dev environment ready to hack on any part of the Foreman? Perhaps forge can be extended with features-like concept if needed. While we can also start skipping tests, I'd still like to have a standard way to deploy dev environment for libvirt integration and more feature in future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
Foreman and Foreman's dev setup document assumes that libvirt is installed in the system. Without libvirt, Foreman's test suite fails to run (specifically https://github.com/theforeman/foreman/blob/develop/test/integration/host_js_test.rb#L4 - the require immediately stops the suite).
What are the changes introduced in this pull request?
How to test this pull request
Steps to reproduce:
Checklist