Add non-root container user validation - #699
Merged
stejskalleos merged 2 commits intoJul 29, 2026
Merged
Conversation
evgeni
reviewed
Jul 23, 2026
evgeni
reviewed
Jul 23, 2026
Member
|
Tests are failing as expected, as pulp is running as 👍 |
Add a foremanctl test that discovers all running containers using podman ps and validates their configured user with podman inspect. Fail when Config.User is empty, root, or UID 0, and report all non-compliant containers with their image details.
archanaserver
force-pushed
the
container-user-validation
branch
from
July 23, 2026 11:03
77ac553 to
2495547
Compare
evgeni
reviewed
Jul 24, 2026
archanaserver
force-pushed
the
container-user-validation
branch
from
July 28, 2026 07:04
f798ee3 to
dc61ae9
Compare
evgeni
approved these changes
Jul 29, 2026
Member
|
In #716 I took a stab at simplifying the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
The SAT-47250 identified container images configured to run as root, and foremanctl deploys images from multiple repositories, including images whose build pipelines are outside its control. So this adds deployment-level regression coverage to ensure that every running container is explicitly configured to use a non-root user.
What are the changes introduced in this pull request?
podman pspodman inspectHow to test this pull request
steps to reproduce:
./forge test --pytest-args="tests/container_user_test.py -vv"Config.User.Checklist