Fix httpd proxy backend precedence in deploy-dev playbook - #696
Merged
evgeni merged 1 commit intoJul 31, 2026
Merged
Conversation
9 tasks
Contributor
Author
|
Updated the description with some additional info about how the bug was introduced and then surfaced. |
jeremylenz
force-pushed
the
fix-httpd-proxy-backend-precedence
branch
2 times, most recently
from
July 22, 2026 20:26
53db5bd to
6056cac
Compare
ehelms
reviewed
Jul 22, 2026
evgeni
reviewed
Jul 23, 2026
| - role: candlepin | ||
| - role: httpd | ||
| vars: | ||
| httpd_foreman_backend: "http://localhost:3000" |
Member
There was a problem hiding this comment.
I am debating whether these should be set in a devel.yaml that we load last in vars_files. Seems a bit cleaner to me, but certainly not blocking.
Contributor
Author
There was a problem hiding this comment.
I am beginning to be convinced. any other opinions?
Member
There was a problem hiding this comment.
The other person with opinions is out, so we can merge quickly behind his back :p
jeremylenz
force-pushed
the
fix-httpd-proxy-backend-precedence
branch
from
July 30, 2026 19:28
6056cac to
e7052e7
Compare
Add a development vars file (devel.yaml) loaded after base.yaml in vars_files to override the Unix socket backend with http://localhost:3000. Previously, the override was in the play-level vars block, which has lower precedence than vars_files and was silently ignored. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jeremylenz
force-pushed
the
fix-httpd-proxy-backend-precedence
branch
from
July 31, 2026 13:58
e7052e7 to
0e2723b
Compare
evgeni
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
The deploy-dev playbook sets
httpd_foreman_backend: "http://localhost:3000"in the play-levelvars:block, butsrc/vars/base.yaml(loaded viavars_files:) overrides it with the Unix socket path. In Ansible's variable precedence,vars_filesbeatsvars, so httpd was always configured to proxy to a nonexistent Unix socket instead of TCP port 3000, resulting in 503 errors.This was latent since
eedbe40(March 2025) when Unix socket support was added tobase.yaml, but went unnoticed because thevars:block originally appeared belowvars_files:in the YAML, and the ordering happened to make the override work. #623 ("Move flavor default into playbook vars", July 6 2026) movedvars:abovevars_files:, which broke the accidental ordering and surfaced the bug.What are the changes introduced in this pull request?
development/vars/devel.yamlwith dev-specific variable overrides (currentlyhttpd_foreman_backend)vars_filesso it overridesbase.yamlat the same precedence levelvars:How to test this pull request
./forge deploy-dev --target-host localhost/etc/httpd/conf.d/foreman.confcontainsProxyPass / http://localhost:3000/(not a Unix socket path)Checklist
🤖 Generated with Claude Code