Refresh all the CAs - #679
Draft
evgeni wants to merge 3 commits into
Draft
Conversation
Member
Author
|
This includes #671 for reasons to build ontop of the changes there |
ehelms
reviewed
Jul 20, 2026
| ./foremanctl certificate-bundle proxy.example.com \ | ||
| --certificate-source=${{ matrix.certificate_source }} \ | ||
| ${{ matrix.certificate_source == 'custom_server' && '--certificate-server-certificate /root/custom-certificates/certs/proxy.example.com.crt --certificate-server-key /root/custom-certificates/private/proxy.example.com.key' || '' }} | ||
| - name: Refresh CA to ensure it doesn't break the bundle |
Member
There was a problem hiding this comment.
I don't understand what this is testing.
Member
Author
There was a problem hiding this comment.
The naïve idea was:
- deploy foreman
- create bundle for a proxy
- renew ca
- see that the previously created bundle still works (assuming the certificate has new expiration dates, but otherwise was not changed)
Member
There was a problem hiding this comment.
Does the bundle get re-created? Or just testing that the certs in the bundle before renewal continue to work?
Member
Author
There was a problem hiding this comment.
No recreation, "old bundle still works" is basically the test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
What are the changes introduced in this pull request?
How to test this pull request
Steps to reproduce:
Checklist