Skip to content

Mark tests with the appropriate feature - #657

Merged
ehelms merged 2 commits into
theforeman:masterfrom
ekohl:mark-katello-tests
Jul 15, 2026
Merged

Mark tests with the appropriate feature#657
ehelms merged 2 commits into
theforeman:masterfrom
ekohl:mark-katello-tests

Conversation

@ekohl

@ekohl ekohl commented Jul 14, 2026

Copy link
Copy Markdown
Member

Why are you introducing these changes? (Problem description, related links)

As part of #511 I've been looking at deploying Foreman without Katello. This properly marks tests so they're only executed when the katello feature is present.

What are the changes introduced in this pull request?

  • It adds the katello feature marker to tests that require Katello

How to test this pull request

Steps to reproduce:

  • Deploy Foreman with Katello and verify the tests still run

Deployment without Katello isn't supported yet, so no need to test that yet.

Checklist

  • Tests added/updated (if applicable)
  • Documentation updated (if applicable)

Comment thread tests/httpd_test.py Outdated
assert cmd.stdout == '200'


@pytest.mark.feature('katello')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those also apply to standalone proxies that have content

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yes, I wrote this before foreman-proxy-content was a flavor. It ties into some work I have in #527, in particular 5a6cf5f. I'll remove it from this PR and move it over there so I won't forget.

@ekohl
ekohl force-pushed the mark-katello-tests branch from f191de7 to a27250f Compare July 15, 2026 11:13
@ehelms
ehelms merged commit 8267876 into theforeman:master Jul 15, 2026
14 of 16 checks passed
@ekohl
ekohl deleted the mark-katello-tests branch July 15, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants