Add foreman_ansible by ehelms · Pull Request #444 · theforeman/foremanctl

ehelms · 2026-04-02T18:42:41Z

No description provided.

ehelms · 2026-04-06T20:14:03Z

This relies on theforeman/foreman-oci-images#25 first

ehelms · 2026-04-08T20:23:35Z

I started adding this to help ensure the IoP use-case could work out of the box by having ansible support for remediation. There is more nuance and testing for this feature that needs to happen to be complete.

When I test this locally with the updated containers built locally, I run into the hammer sync failing with no clear reason why. That will need investigation, i.e.:

hammer ansible roles sync

adamruzicka

@ehelms what are your plans with this?

evgeni · 2026-07-29T10:43:01Z

@adamruzicka I cleaned up what I disliked, but would now require someone with Ansible knowledge to look at this :)

adamruzicka

Seems to work well (ad-hoc rex-like jobs, role management, role application, reports from roles). Some minor suggestions inline

adamruzicka · 2026-07-30T07:42:44Z

+
+- name: Create ansible roles directory
+  ansible.builtin.file:
+    path: /var/lib/foreman-proxy/ansible/roles


Previously we relied on /etc/ansible/roles for "user roles" (and s/role/collection/g). Having everthing in /var/lib would be cleaner, but also make the migration harder. Personally I'd be willing to make that tradeoff, but still worth calling out.

adamruzicka · 2026-07-30T07:44:22Z

+      Volume=/var/lib/foreman-proxy/ansible/roles:/etc/ansible/roles:rw,Z,U
+      Volume=/var/lib/foreman-proxy/ansible/collections:/etc/ansible/collections:rw,Z,U


Why rw? I'd expect the proxy to only consume the content that's there.

Also til about U, nice.

adamruzicka · 2026-07-30T07:46:35Z

+export ANSIBLE_LOCAL_TEMP="/tmp"
+export ANSIBLE_HOST_KEY_CHECKING="False"
+export ANSIBLE_ROLES_PATH="/etc/ansible/roles:/usr/share/ansible/roles"
+export ANSIBLE_COLLECTIONS_PATHS="/etc/ansible/collections:/usr/share/ansible/collections"


[DEPRECATION WARNING]:
ANSIBLE_COLLECTIONS_PATHS option, does not fit var naming standard, use the singular form ANSIBLE_COLLECTIONS_PATH instead. This feature will be removed from ansible-core in version 2.19. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

Suggested change

export ANSIBLE_COLLECTIONS_PATHS="/etc/ansible/collections:/usr/share/ansible/collections"

export ANSIBLE_COLLECTIONS_PATH="/etc/ansible/collections:/usr/share/ansible/collections"

adamruzicka · 2026-07-30T07:49:18Z

@@ -0,0 +1,13 @@
+export ANSIBLE_CALLBACK_WHITELIST="theforeman.foreman.foreman"


Iirc whitelist was replaced with the one below in ansible 2.15. It should be safe to drop this one.

Suggested change

export ANSIBLE_CALLBACK_WHITELIST="theforeman.foreman.foreman"

adamruzicka · 2026-07-30T14:39:24Z

+ROLE_NAME = "theforeman.foremanctltest"
+
+
+def test_foreman_ansible_plugin_installed(foremanapi):


#713 (comment) :)

that's a shiny mirror you have there. where did you get it?

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

pr-processor Bot added the Not yet reviewed label Apr 2, 2026

arvind4501 reviewed Apr 6, 2026

View reviewed changes

Comment thread src/features.yaml Outdated

pr-processor Bot removed the Not yet reviewed label Apr 6, 2026

ehelms force-pushed the add-foreman-ansible branch from 64e0224 to e06a7f9 Compare April 6, 2026 20:12

Gauravtalreja1 reviewed Apr 7, 2026

View reviewed changes

Comment thread .github/workflows/test.yml Outdated

evgeni reviewed Apr 14, 2026

View reviewed changes

Comment thread tests/foreman_ansible_test.py Outdated

evgeni reviewed Apr 14, 2026

View reviewed changes

Comment thread tests/feature/ansible/base_test.py

pablomh mentioned this pull request May 12, 2026

Add Ansible integration feature #506

Closed

5 tasks

arvind4501 mentioned this pull request May 18, 2026

Expose user enabled features as pytest markers #508

Merged

2 tasks

adamruzicka reviewed Jul 20, 2026

View reviewed changes

Comment thread src/roles/foreman_proxy/templates/settings.d/ansible.yml.j2 Outdated

ehelms force-pushed the add-foreman-ansible branch 4 times, most recently from ba72146 to b1c30e7 Compare July 24, 2026 01:00

evgeni force-pushed the add-foreman-ansible branch 2 times, most recently from 594cbd5 to f3de969 Compare July 28, 2026 14:58

evgeni reviewed Jul 28, 2026

View reviewed changes

Comment thread tests/feature/ansible/base_test.py Outdated

evgeni reviewed Jul 28, 2026

View reviewed changes

Comment thread tests/feature/ansible/base_test.py Outdated

adamruzicka reviewed Jul 28, 2026

View reviewed changes

Comment thread tests/feature/ansible/base_test.py Outdated

Comment thread src/features.yaml Outdated

evgeni reviewed Jul 28, 2026

View reviewed changes

Comment thread tests/feature/ansible/base_test.py Outdated

evgeni force-pushed the add-foreman-ansible branch 3 times, most recently from 4321df6 to 6a330e3 Compare July 29, 2026 08:44

adamruzicka mentioned this pull request Jul 29, 2026

Allow ansible in containerized deployments theforeman/foreman-documentation#5118

Draft

8 tasks

adamruzicka reviewed Jul 30, 2026

View reviewed changes

Add ansible feature for smart proxy and Foreman

619b352

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

evgeni added 8 commits July 30, 2026 17:44

test the feature in foreman-proxy/base_test

f8aa956

simplify ansible client setup

d93cbb8

assign proxy to org

747b307

depend on rex, not tasks

91ade83

don't add ansible for upgrades - 3.19 has no ansible support

d6d1f9b

stop, api time!

3123cec

no podman exec

85c4014

use foreman_plugins fixture

2f0f2c4

evgeni force-pushed the add-foreman-ansible branch from f7c4467 to 2f0f2c4 Compare July 30, 2026 15:44

		Volume=/var/lib/foreman-proxy/ansible/roles:/etc/ansible/roles:rw,Z,U
		Volume=/var/lib/foreman-proxy/ansible/collections:/etc/ansible/collections:rw,Z,U

	export ANSIBLE_COLLECTIONS_PATHS="/etc/ansible/collections:/usr/share/ansible/collections"
	export ANSIBLE_COLLECTIONS_PATH="/etc/ansible/collections:/usr/share/ansible/collections"

		@@ -0,0 +1,13 @@
		export ANSIBLE_CALLBACK_WHITELIST="theforeman.foreman.foreman"

		ROLE_NAME = "theforeman.foremanctltest"


		def test_foreman_ansible_plugin_installed(foremanapi):

Uh oh!

Conversation

ehelms commented Apr 2, 2026

Uh oh!

Uh oh!

ehelms commented Apr 6, 2026

Uh oh!

Uh oh!

ehelms commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adamruzicka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

evgeni commented Jul 29, 2026

Uh oh!

adamruzicka left a comment

Choose a reason for hiding this comment

Uh oh!

adamruzicka Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

adamruzicka Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

adamruzicka Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

adamruzicka Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

adamruzicka Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

evgeni Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ehelms commented Apr 8, 2026 •

edited

Loading