Fixes #39683 - Scope host group Puppet class completion - #453
Open
jakduch wants to merge 1 commit into
Open
Conversation
Use host group assignments when completing Puppet class values on the host group list. Keep direct, inherited, and config group assignments while excluding classes assigned only to hosts. Assisted-By: Codex 5.6 Sol High
jakduch
force-pushed
the
fix/39683-hostgroup-puppetclass-completion
branch
from
August 21, 2026 12:57
de09128 to
7b3ce1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #39683 as a follow-up to foreman_puppet #450.
Host group Puppet class completion reused the host assignment scope, so it suggested classes assigned only to hosts. Pass the resource being completed to the Puppet class completer and use a dedicated host group assignment scope restricted to host groups visible in the current organization and location. Direct and inherited host group assignments and classes provided through config groups remain available.
Testing
git diff --checkpassesAI usage disclosure
Per the community discussion on AI policy, the issue was investigated and the changes, tests, and PR wording were prepared with the assistance of Codex 5.6 Sol High. The resulting changes were reviewed before submitting. The commit also includes an
Assisted-Bytrailer.