Add containerized custom ssl certs renewal - #4989
Merged
Merged
Conversation
github-actions
Bot
added
Needs tech review
|
The PR preview for ea87ae2 is available at theforeman-foreman-documentation-preview-pr-4989.surge.sh The following output files are affected by this PR: |
jafiala
marked this pull request as ready for review
June 30, 2026 08:06
Contributor
Author
|
Unused modules is triggered by the guide being unready. I will rebase tomorrow when #4983 is merged. |
ShimShtein
approved these changes
Jun 30, 2026
ShimShtein
left a comment
ShimShtein
left a comment
Member
There was a problem hiding this comment.
I am not sure I would use the if statement, there is no other option to set the certificates.
Maybe also worth mentioning that the files should be there too.
jafiala
added
tech review done
custom ssl certs renewal
jafiala
force-pushed
the
custom-cert-renewal-SAT-44882
branch
from
July 1, 2026 07:34
2546c0d to
56139fe
Compare
Contributor
Author
|
@maximiliankolb Please ack when you have time, I rebased against master and the previews and checks work correctly now. |
jafiala
added
style review done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Add information on renewing custom ssl certs that are user-managed
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://redhat.atlassian.net/browse/SAT-44882
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: