Copilot/add relay functionality#2
Open
thecem wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements a robust failsafe mechanism for both consumption and production limits in the HEMS relay and FNN modules. It introduces separate configuration options for production and consumption failsafe limits, ensures minimum durations for failsafe states, and adds comprehensive error handling and testing for these scenarios.
Failsafe Mechanism Enhancements:
failsafeProductionActivePowerLimit) alongside the existing consumption failsafe limit, including validation to prevent negative values. [1] [2] [3] [4] [5] [6] [7] [8]failsafeDurationMinimum) for both consumption and production, with validation to prevent negative values. [1] [2] [3] [4] [5]Production and Consumption Logic Refactoring:
Configuration and Validation:
Testing Improvements:
Relay Module Updates:
These changes ensure that both production and consumption limits can safely fall back to a configured failsafe state in case of input signal errors, with robust duration and validation logic to prevent misconfiguration and ensure predictable recovery.