Skip to content

Calculator finished#6

Open
klaudia021 wants to merge 1 commit into
the-csharp-academy:mainfrom
klaudia021:main
Open

Calculator finished#6
klaudia021 wants to merge 1 commit into
the-csharp-academy:mainfrom
klaudia021:main

Conversation

@klaudia021

Copy link
Copy Markdown

Hi everyone. I just finished my Calculator program.

I followed the instruction on the Microsoft site, but when I started writing my own code, I needed to restructure it.
I kept the initial logic from the tutorial though.

I tried to add unit tests, but since almost all my functions rely on console inputs, I could not make them work. What I've found online was that I needed to add another layer of abstraction using interfaces, but I decided that re-writing the project for this purpose is probably not the best option right now, so I deleted the tests and I will try to add them in the next project.

Please review my work. Thank you kindly.

@DSills735 DSills735 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Sorry for the delay in reviewing. you have the right idea on unit testing! From here on out you have the option to do them as a challenge. IMO, as you found you are correct, as they really just dont fit in on this project with how minimal the validation really is.

What you said about reowrking the project is great instinct, and promotes good learning! You will more than likely build calculators again using new frameworks and things in the future.

My only minor critique, is use Console.Clear() as often as practical, because it really helps clean the UI on console applications!

Overall good job, project approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants