Calculator finished#6
Open
klaudia021 wants to merge 1 commit into
Open
Conversation
DSills735
approved these changes
Jun 8, 2026
DSills735
left a comment
There was a problem hiding this comment.
Good work! Sorry for the delay in reviewing. you have the right idea on unit testing! From here on out you have the option to do them as a challenge. IMO, as you found you are correct, as they really just dont fit in on this project with how minimal the validation really is.
What you said about reowrking the project is great instinct, and promotes good learning! You will more than likely build calculators again using new frameworks and things in the future.
My only minor critique, is use Console.Clear() as often as practical, because it really helps clean the UI on console applications!
Overall good job, project approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone. I just finished my Calculator program.
I followed the instruction on the Microsoft site, but when I started writing my own code, I needed to restructure it.
I kept the initial logic from the tutorial though.
I tried to add unit tests, but since almost all my functions rely on console inputs, I could not make them work. What I've found online was that I needed to add another layer of abstraction using interfaces, but I decided that re-writing the project for this purpose is probably not the best option right now, so I deleted the tests and I will try to add them in the next project.
Please review my work. Thank you kindly.