Skip to content

do not store secrets in configmaps#3

Open
vixns wants to merge 2 commits into
th0th:mainfrom
vixns:nosecretsincm
Open

do not store secrets in configmaps#3
vixns wants to merge 2 commits into
th0th:mainfrom
vixns:nosecretsincm

Conversation

@vixns

@vixns vixns commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@th0th

th0th commented Oct 14, 2024

Copy link
Copy Markdown
Owner

Thanks for the PR 💐

Even tough I agree with the idea of "not storing sensitive information in the configmap", it doesn't feel right to move all configuration to a secret. If there is a way to separate configuration options like hosts, ports etc from sensitive information, we can go that way maybe?

@vixns

vixns commented Oct 14, 2024

Copy link
Copy Markdown
Contributor Author

"One or more TOML files can be read by passing --config config.toml multiple times. " ( source: https://listmonk.app/docs/configuration/ )
Splitting the configuration between a CM and a secret seems doable, it depends how toml files are merged. Another way would be to use environment variables for non sensitive content instead of a configmap.

@th0th

th0th commented Oct 14, 2024

Copy link
Copy Markdown
Owner

"One or more TOML files can be read by passing --config config.toml multiple times. " ( source: https://listmonk.app/docs/configuration/ ) Splitting the configuration between a CM and a secret seems doable, it depends how toml files are merged. Another way would be to use environment variables for non sensitive content instead of a configmap.

Do you know if there is any configuration that is doable by the config file, but not the environment variables? If everything is configurable by environment variables, we can go that way, and move sensitive information to a secret.

@elthariel

Copy link
Copy Markdown

Secrets aren't that secret in k8s, but in doubt, it's better to have everything in a secret than having a secret in a configmap :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants