Skip to content

fix(Engine): remove "Hide the Save button" game option#1925

Merged
alexwarren merged 1 commit into
mainfrom
fix/remove-hide-save-button-option
Jul 23, 2026
Merged

fix(Engine): remove "Hide the Save button" game option#1925
alexwarren merged 1 commit into
mainfrom
fix/remove-hide-save-button-option

Conversation

@alexwarren

Copy link
Copy Markdown
Contributor

Summary

  • Removes the Features-tab checkbox "Hide the Save button on the web player" (turnoffsavebutton attribute), its Core.aslx handling, and the English/German editor translation strings.
  • The option has been mislabeled since it was added in Quest 5.7 (2017): it hides the whole #controlButtons div, which contains the Debug and panes-toggle hamburger buttons alongside Save, not just Save. On narrow/mobile layouts the hamburger button is the only way to show/hide the sidebar panes, and #cmdSave's click handler now opens the multi-slot save/load dialog — so enabling this option silently breaks more UI than it advertises and blocks saving entirely.

Test plan

  • dotnet build --configuration Release succeeds
  • dotnet test --configuration Release — all 327 tests pass across EngineTests, PlayerCoreTests, EditorCoreTests, WebPlayerTests, LegacyTests

🤖 Generated with Claude Code

Since it was added in 2017 it has hidden the entire #controlButtons
div (Debug + Save + panes-toggle hamburger), not just Save — the
hamburger button is the only way to show/hide sidebar panes on
narrow layouts, and Save is now the entry point to the multi-slot
save/load dialog, so enabling this option breaks more than it
advertises.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@alexwarren
alexwarren enabled auto-merge (squash) July 23, 2026 11:44
@alexwarren
alexwarren merged commit d111239 into main Jul 23, 2026
7 checks passed
@alexwarren
alexwarren deleted the fix/remove-hide-save-button-option branch July 23, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant