Repository navigation
Error trackers: count the template launcher as library code - #6
Merged
Merged
Conversation
A forked worker's stack trace ends in the launcher it was forked from, not in artisan. The launcher was a copy in the private runtime dir, outside vendor/, so error trackers counted it as the app's code: Flare dropped every frame above it (only the launcher was left for a job failing in vendor code), Sentry marked it in-app, and Nightwatch placed such exceptions there (#5). Templates now start through a link in the runtime dir to the package's own bin/template.php. PHP resolves the link, so traces name the launcher in the app's vendor/, while the command line keeps the runtime path, with nothing in it horizon:purge could match. Links whose release is gone are removed; where no link can be made, the copy is used as before. The workbench installs the package as a copy instead of the path repository's symlink, as an install from Packagist has, and records what Flare, Sentry and Nightwatch make of a job failing in vendor code; stock and prefork must match, under Horizon and queue:work. The test fails without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5.
A forked worker's stack trace ends in the launcher it was forked from, not in
artisan. The launcher was a copy in the private runtime directory, outsidevendor/, so error trackers counted it as the app's own code:Templates now start through a link in the runtime directory to the package's own
bin/template.php. PHP resolves the link, so traces name the launcher in the app'svendor/, while the command line keeps the runtime path, with nothing in ithorizon:purgecould match. Links whose release is gone are removed; where no link can be made, the copy is used as before.Tests: the workbench installs the package as a copy instead of the path repository's symlink, as an install from Packagist has, and a new fixture records what Flare, Sentry and Nightwatch make of a job failing in vendor code. Stock and prefork must match, under Horizon and
queue:work. Without the fix it fails with exactly the reported trace; with it, all Docker suites pass locally (Horizon host mode, master spawns its template,queue:work), as do Unit and Mechanics.