fix: SW-2535 make table action cells reachable on touch (+ alwaysVisible) - #218
Open
boramyi-ts wants to merge 2 commits into
Open
fix: SW-2535 make table action cells reachable on touch (+ alwaysVisible)#218boramyi-ts wants to merge 2 commits into
boramyi-ts wants to merge 2 commits into
Conversation
TableCell variant="action" was opacity-0 until row hover, so on touch (no hover) the row actions were invisible at rest and undiscoverable. - Default now reveals action cells on coarse pointers (pointer-coarse: opacity-100) so they always show on tablets/phones; mouse devices keep the reveal-on-hover behavior unchanged. - New `alwaysVisible` prop opts out of the fade entirely (show at rest on every device), for consumers that want persistent row actions. - Stories: added a default-hidden-at-rest assertion to Row Actions and a new Persistent Row Actions story (alwaysVisible) asserting opacity 1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No issues found
About Unblocked
Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.
📖 Documentation — Learn more in our docs.
💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions.
👍 Give feedback — React to comments with 👍 or 👎 to help us improve.
⚙️ Customize — Adjust settings in your preferences.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SW-2535 — Action cell bug
TableCell variant="action"wasopacity-0until row hover, so on touch devices (no hover) the row-action trigger (the⋯menu) was invisible at rest and undiscoverable.opacity-0keeps it in the a11y tree and tappable, but a sighted touch user can't see it's there.Fix
pointer-coarse:opacity-100) — always visible on tablets/phones, where there's no hover to reveal them. Mouse devices keep reveal-on-hover unchanged.alwaysVisibleprop opts out of the fade entirely (show at rest on every device) for consumers that want persistent row actions.pointer: fine)pointer: coarse)alwaysVisibleKeyboard (focus-within reveal) and screen readers (opacity-0 stays operable) were already fine; this closes the touch gap.
Before → After — touch (iPad emulation)
The action column is empty at rest before; after, the
⋯shows on every row.alwaysVisibleopt-in (desktop)Testing
yarn typecheck✓ ·yarn lint✓ (0 warnings) · Storybook play 37/37.alwaysVisible) asserting opacity 1.pointer: coarse): touch → opacity 1, desktop → opacity 0.🤖 Generated with Claude Code