feat: SW-2591 add size prop to Checkbox and RadioGroup - #213
Open
boramyi-ts wants to merge 3 commits into
Open
Conversation
Box scale (SW-2591): xs 14 / sm 16 / default 16 / lg 20. default keeps today's 16px so existing checkboxes/radios are unchanged; xs and lg are opt-in. The check icon and radio dot scale with the box. RadioGroup accepts size and provides it via context so a group can be sized once; RadioGroupItem can still override per item. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No issues found
About Unblocked
Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.
📖 Documentation — Learn more in our docs.
💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions.
👍 Give feedback — React to comments with 👍 or 👎 to help us improve.
⚙️ Customize — Adjust settings in your preferences.
owilliams-tetrascience
approved these changes
Sep 10, 2026
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SW-2591 — add
sizeprop to Checkbox & RadioGroupJira: SW-2591
The box-control slice of the input-size harmonization (after toggles #211 and the input family #212). Adds a
sizeprop to the two box controls on a 14 / 16 / 18 / 20-style ladder — but, per the design call,defaultstays today's 16px so nothing changes for existing usage:xsandlgare opt-in;sm/defaultare both 16 today. The check icon and the radio dot scale with the box.sizevariant; check icon steps 12 / 14 / 16.sizeand provides it via context so a group is sized once;RadioGroupItemcan override per item. The inner dot scales 6 / 8 / 10.xs · default · lg
Tests
New
ExtraSmall/Largestories assert the rendered box (checkbox & radio 14px xs, 20px lg) +data-size; the radio story also verifies the groupsizeflows to items. Checkbox + RadioGroup suites pass (9/9) incl. axe; typecheck + lint clean. Zephyr ids viazephyr_sync.No visual change to existing checkboxes/radios (default = 16). This completes the input controls for SW-2591 except the pill/track groups (Switch, Slider), which need internal track/thumb changes and are separate follow-ups.
🤖 Generated with Claude Code