fix: SW-2583 Combobox radius consistency + default multi-select chevron - #206
Closed
boramyi-ts wants to merge 3 commits into
Closed
fix: SW-2583 Combobox radius consistency + default multi-select chevron#206boramyi-ts wants to merge 3 commits into
boramyi-ts wants to merge 3 commits into
Conversation
The multi-select ComboboxChips container used rounded-md (8px) while the single-select ComboboxInput (input-group), the popup ComboboxContent, and the sibling Select / Input all use rounded-lg (10px) — so single- and multi-select comboboxes side-by-side didn't read as one control family. Aligns ComboboxChips to rounded-lg. (Audited the other Combobox parts: the popup is already rounded-lg; the individual chip pill rounded-sm and the list item rounded-md are their own tokens, left as-is.) Adds a "Radius / Single vs multi" story that asserts the chips container and the input-group share one corner-radius token. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
boramyi-ts
temporarily deployed
to
artifactory-prod
September 8, 2026 18:32 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No issues found
About Unblocked
Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.
📖 Documentation — Learn more in our docs.
💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions.
👍 Give feedback — React to comments with 👍 or 👎 to help us improve.
⚙️ Customize — Adjust settings in your preferences.
…(SW-2583)
The single-select ComboboxInput shows a chevron toggle (showTrigger, default
true) but the multi-select ComboboxChips showed none — an inconsistent
affordance between the two variants. Adds a matching `showTrigger` prop to
ComboboxChips (default true) that renders the ComboboxTrigger chevron at the
inline end, so both variants read the same. Opt out with showTrigger={false}.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
boramyi-ts
temporarily deployed
to
artifactory-prod
September 8, 2026 18:46 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
boramyi-ts
changed the title
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Contributor
Author
|
Superseded by #212 (SW-2591 input sizing) and closing this.
Both changes ship in #212 with tests, so keeping this open would just create a merge conflict on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SW-2583 — Combobox: consistent corner radius (+ default multi-select chevron)
Jira: SW-2583
1. Corner radius (the ticket)
The multi-select
ComboboxChipscontainer usedrounded-md(8px), while the single-selectComboboxInput(itsinput-group), the popupComboboxContent, and the siblingSelect/Inputall userounded-lg(10px) — so single- and multi-select comboboxes side-by-side didn't read as the same control family.Fix: align
ComboboxChipstorounded-lg. Audited the rest — popup + input-group were alreadyrounded-lg; the individual chip pill (rounded-sm) and list item (rounded-md) are their own tokens, left unchanged.2. Default chevron on the multi-select
While aligning the two variants, the multi-select had no dropdown-toggle affordance:
ComboboxInputrenders a chevron (showTrigger, defaulttrue) butComboboxChipsrendered none. Added a matchingshowTriggerprop toComboboxChips(defaulttrue) that renders theComboboxTriggerchevron at the inline end, so both variants read the same. Opt out withshowTrigger={false}.Before / After (radius annotated)
Before: input 10px + chevron, chips 8px + no chevron. After: both 10px, both with the chevron.
Tests
Radius / Single vs multistory asserts the chips container and input-group share one corner-radius token (regression guard). typecheck + lint clean; the full Combobox play-test suite passes (existing multi-select stories still pass with the added chevron). Zephyr id generated for the new story.🤖 Generated with Claude Code