Secure Map Service - #1277
Open
jakeymac wants to merge 29 commits into
Open
Conversation
* Added middleware to allow apps to require users to be authenticated with Oauth or be redirected to settings to get their account connected * Added GRiD backend for Oauth authentication * Added new basemap capabilities to allow secure map services to be used as basemaps * Added proxy url route and view for secure requests to SecureMapService endpoints with authentication data * Added helper methods for interacting with SecureMapServices and settings
* Added better error logging in fetch_response util method * Updated secure map service proxy controller to accept any kind of request, not just GET * Added form_id and draw attributes to MapLayout to allow for drawing and passing geometry to forms * Fixed user_data in grid backend
6 tasks
|
coverage: 99.507% (-0.5%) from 99.993% — secure-map-service into main |
…re map service settings * Updated portal_config.yml file to have a generated SALT_KEY to use for encryption, updated settings.py to use this value * Updated secure map proxy endpoint to always include browser params(params supplied from the browser(bbox, etc))
jakeymac
marked this pull request as ready for review
August 3, 2026 17:19
…basemaps when using a proxy endpoint * Updated generate_request helper function in SecureMapServiceSetting class to return a lazy request to avoid error when using a secure map service as a basemap with a proxy endpoint * Updated generate_request, build_layer, and fetch_response to be private * Added _resolve_secure_map_service as a lazy target for get_secure_map_service
jakeymac
commented
Aug 7, 2026
| def _generate_request(self, param_overrides=None): | ||
| """ | ||
| Generate a request to the secure map service, including any necessary authentication headers or parameters. | ||
| """ |
Contributor
Author
There was a problem hiding this comment.
@swainn I just noticed this function doesn't handle the OAuth2 token if the service setting is not set to use the proxy endpoint... Thoughts on how that should be handled?
Contributor
Author
There was a problem hiding this comment.
If we want to worry about the OAuth token here at all, maybe we have a note/warning to just use the service as a layer or a response instead of getting the endpoint url without the OAuth token, or should this function perhaps return the OAuth token as well as the url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This merge adds new capabilities to Tethys with Secure Map Services that allow for secure storing of authentication data used to access Map or Imagery services.
Changes Made to Code
Related PRs, Issues, and Discussions
Additional Notes
Quality Checks